Fix nbconvert handler #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
- Coverage 76.33% 76.32% -0.02%
==========================================
Files 110 110
Lines 9816 9819 +3
Branches 1067 1067
==========================================
+ Hits 7493 7494 +1
- Misses 1943 1944 +1
- Partials 380 381 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the call to nbconvert's
get_exporterfunction is not thread-safe:jupyter_server/jupyter_server/services/nbconvert/handlers.py
Line 23 in 450010e
And I can see that JupyterLab makes multiple concurrent requests to
/api/nbconvert. This PR works around that issue using a lock.Fixes jupyterlab/jupyterlab#10442